chore: exclude **/build/ from eslint ignorePatterns#1082
Merged
msluszniak merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
CMake-generated compiler_depend.ts timestamp files inside local build/ directories cause parsing errors when lint runs from a workspace that has built the native test suite. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
qvpiotr
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**/build/to ESLint'signorePatternsso local CMake build artifacts don't trip the linter.compiler_depend.tstimestamp files (the.tshere means "timestamp", not TypeScript) are written intopackages/react-native-executorch/common/rnexecutorch/tests/build/when the native test suite is built locally. The root lint glob"**/*.{js,ts,tsx}"picks them up and fails withParsing error: Invalid character..gitignoreavoids confusing noise.Test plan
yarn lintpasses cleanly on a workspace with the CMake test build present (so you need to build tests inpackages/react-native-executorch/common/rnexecutorch/testsfirst)